fix: don't send empty arguments to gcloud in the cleanup script #591
Conversation
There was a problem hiding this comment.
Nice catch on the empty arguments!
Looks like the integration test failed due to
TASK [gcp_sql_database : create a database that already exists] ****************
fatal: [testhost]: FAILED! => "changed": false, "msg": "SQL objects can't be updated to ensure data safety"
PLAY RECAP *********************************************************************
testhost : ok=8 changed=2 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
And it seems unrelated to the change. Perhaps some cleanup is needed here on the sql DB resource.
Yeah, the integration weren't running before so this test may have been broken for a while (and the integration tests run sequentially and stop at the first failing test, so there may be other broken tests after this one). We should target getting them all back and running reliably. Probably not a good candidate task for this PR, though :-) |
SUMMARY
When the
scripts/cleanup-project.shcallscleanup_resource()with an empty value for either$extra_list_argor$extra_delete_argit will in turn callgcloudwith the empty argument, which gets misinterpreted.For instance, the script cleans up target http proxies with:
The empty list argument is quoted in the call to
gcloud(as it should be!), which means that the arguments thatgcloudprocesses are['gcloud', 'compute', 'target-http-proxies', 'list', '--project="blahblah"', '--format="csv[no-heading](name)"', '']That last empty string argument is the reason for these log messages:
And it's the reason that the script ultimately fails, as no resources are listed thus no resources are deleted.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION